Generated form dialog of 'any string' contains unexpected '${property}' in content - Githubissues

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!

https://github.com/Microsoft/botframework

MIT License

4.37k stars 4.87k forks source link

Generated form dialog of 'any string' contains unexpected '${property}' in content #2956

Closed yeze322 closed 5 months ago

yeze322 commented 3 years ago

Versions

@microsoft/bf-generate-library/4.10.0 win32-x64 node v12.14.1

Describe the bug

Give a clear and concise description of what the bug is.

In Composer, create a form property typed with "any string", the generated dialog contains unexpected '${property}' in content.

For example

In the Trigger name: age - Add(@${property}Entity)
In the expression value - ${confirmationText('age', @${property}Entity)}.

Schema:

Generated Expression value

Generated Trigger name:

To Reproduce

Steps to reproduce the behavior:

Add a form property typed with "any string"
Generate the dialog with cli
Check the generated dialog content

Expected behavior

Give a clear and concise description of what you expected to happen.

The "${property}" needs to be resolved as the given property name.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

gandiddi commented 5 months ago

Unable to reproduce the issue. It was resolved in the BotFramework-Composer repository. Hence, the issue is being closed.