search

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.37k stars 4.87k forks source link

Convert existing Composer samples to new runtime #3260

Closed clearab closed 8 months ago

clearab commented 3 years ago

In order to minimize disruption to the documentation team, and to facilitate moving towards a combined strategy for Composer and SDK samples, we need to convert all of the existing Composer samples to the new runtime:

https://github.com/microsoft/BotFramework-Composer/tree/main/extensions/samples/assets/projects

They should be removed from the code that ships with Composer, and for now put in the /experimental folder in the bobuilder-samples repository.

tracyboehrer commented 3 years ago

I've created a branch in botbuilder-samples to home these and other samples. This doesn't need to be the final home or folder structure. Rather it's a starting point to collect them.

experimental/composer

https://github.com/microsoft/BotBuilder-Samples/tree/ComposerSamples

tracyboehrer commented 3 years ago

Opening these in Composer will allow for them to be run, but there isn't a host app. Is this using the old runtime? If you then go to settings, and choose custom runtime, the old runtime is ejected.

clearab commented 3 years ago

They'd all need to be converted to be consistent with - but at a minimum that will probably be converting to new runtime + app code

clearab commented 3 years ago

Which I think you can actually do by just opening in Composer, and then ejecting the runtime? Not sure how that looks on disk.