microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.35k stars 4.86k forks source link

Migrate C# samples to Cloud Adapter #3307

Closed mrivera-ms closed 2 years ago

mrivera-ms commented 3 years ago

Some samples have been migrated. This issue tracks the remaining ones.

Samples folder (PR #3481)

Samples/adaptive-dialog folder (PR #3482)

Samples/language-generation folder (PR #3483)

cleemullins commented 3 years ago

Via @tomlm: Double check BotBuilder-Samples/samples/csharp_dotnetcore/13.core-bot at main. It doesn't inject IConfiguration and may not work correctly w/ AppId & Password.

ceciliaavila commented 3 years ago

Hi @mrivera-ms, we see the bots under Migration and Experimental folders are using old versions of the botbuilder packages. Some bots are using version 4.4.3 and others version 4.9.2, while the rest of the samples use the 4.14.1 version. Are these bots intended to be migrated to Cloud Adapter or should we leave them as they are?

mrivera-ms commented 3 years ago

@ceciliaavila, please leave Migration and Experimental as they are. Thank you.

ceciliaavila commented 3 years ago

Via @tomlm: Double check BotBuilder-Samples/samples/csharp_dotnetcore/13.core-bot at main. It doesn't inject IConfiguration and may not work correctly w/ AppId & Password.

We tested the bot with and without credentials and it's working.