microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.34k stars 4.86k forks source link

Error TS2345 for npm run test in experimental/generation/generator #3410

Open BruceHaley opened 3 years ago

BruceHaley commented 3 years ago

@microsoft/bf-generate-library: > @microsoft/bf-generate-library@1.0.0 test D:\a\1\s\experimental\generation\generator\packages\library @microsoft/bf-generate-library: ^ @microsoft/bf-generate-library: > nyc --extension .ts mocha --forbid-only "test/*/.test.ts" @microsoft/bf-generate-library: TSError: ⨯ Unable to compile TypeScript: @microsoft/bf-generate-library: ----------|----------|----------|----------|----------|-------------------|

@microsoft/bf-generate-library: test/generate.test.ts(336,66): error TS2345: Argument of type 'import("D:/a/1/s/experimental/generation/generator/node_modules/botbuilder-dialogs-adaptive-runtime-core/lib/serviceCollection").ServiceCollection' is not assignable to parameter of type 'import("D:/a/1/s/experimental/generation/generator/node_modules/botbuilder-dialogs-adaptive/node_modules/botbuilder-dialogs-adaptive-runtime-core/lib/serviceCollection").ServiceCollection'.

@microsoft/bf-generate-library: Types have separate declarations of a private property 'dependencies'. @microsoft/bf-generate-library: at createTSError (D:\a\1\s\experimental\generation\generator\node_modules\ts-node\src\index.ts:434:12)

Repros locally with:

lerna bootstrap --hoist npm run build npm run test

This error can be seen failing the build BotBuilder-bf-generate-JS/20210817.264388 in the task npm run test.

gandiddi commented 2 months ago

I ran npm run test locally at the path BotBuilder-Samples\experimental\generation\generator. It is showing: "Successfully ran target test for 0 projects."

image
gandiddi commented 2 months ago

The error is not reproducible locally, but it's not finding any projects. As discussed with @tracyboehrer, I am assigning this to him.