microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.39k stars 4.88k forks source link

Teams asking user to enter 6 digit code? #3779

Closed catmanjan closed 2 years ago

catmanjan commented 2 years ago

Github issues for C# /JS / Java/ Python should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Sample information

BotBuilder-Samples/samples/csharp_dotnetcore/52.teams-messaging-extensions-search-auth-config

Describe the bug

When I deploy this sample the user is prompted to enter a 6 digit code to log in - however there is nowhere to enter it as they are accessing the bot as a compose message extension - I would expect either the user is not prompted and SSO happens, or they are asked to enter their credentials in the pop up that shows the 6 digit code

To Reproduce

Steps to reproduce the behavior:

  1. Deploy the sample in Azure
  2. Try to use it

Expected behavior

Users either don't get asked to log in, or they log in a normal username/password prompt rather than a 6 digit code

Screenshots

If applicable, add screenshots to help explain your problem. image

breakingram commented 2 years ago

Hello @catmanjan, I'm investigating this one.

breakingram commented 2 years ago

Hi @catmanjan

Looks like I was not able to reproduce this issue.

Steps I took: 1) Clone sample 52.teams-messaging-extensions-search-auth-config (main branch) 2) Added Azure AD V2 authentication to the Teams bot 3) Set up ngrok tunneling solution 4) Updated appsettings.json and manifest.json 5) Ran the bot and tested in teams

Attempted to login, It seems it did not ask for 6 digit secret. I logged in with email and password. image

After login

#

I noticed in your attached link

BotBuilder-Samples/samples/csharp_dotnetcore/52.teams-messaging-extensions-search-auth-config

The sample is not on main branch and its TargetFramework is .netcore 2.1 with outdated packages. https://github.com/microsoft/BotBuilder-Samples/blob/a66d06f7feff10168591cbac0181ae2ec09f29bd/samples/csharp_dotnetcore/52.teams-messaging-extensions-search-auth-config/TeamsMessagingExtensionsSearchAuthConfig.csproj#L4

#

Have you tried running the sample from the main branch? https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/csharp_dotnetcore/52.teams-messaging-extensions-search-auth-config

catmanjan commented 2 years ago

Yes I've tried that, note that I am deploying the app to my organisation through Teams administration rather than through "Upload an app" in the teams client

catmanjan commented 2 years ago

Also I am not using ngrok because the app was deployed to Azure as it would be in a real scenario

catmanjan commented 2 years ago

Here's a Fiddler trace of the requests that happen between me clicking "Sign in" and the 6 digit code appearing

image

catmanjan commented 2 years ago

Also, one last thing, I noticed that I don't get prompted to provide a 6 digit code when using the web version of Teams, it only happens in the desktop version

In fact on the web I don't even get asked to pick an account, I just click sign in, a pop up briefly appears and then I get search results

ALSO further to this - after clicking sign in from the web version of Teams, the desktop version is no longer showing the 6 digit code - so I think there is some bigger issue at play here with the desktop version of Teams

breakingram commented 2 years ago

Thank you for the update @catmanjan, we are investigating further.

breakingram commented 2 years ago

Hi @catmanjan

After publishing the bot to azure, it seems I'm not able to reproduce this issue.

It gives the option to log in with a username and password and not 6 digit code. Note, I uploaded the manifest.zip to Teams (in the Apps view click "Upload a custom app")

Using Teams Version 1.5.00.17971 (64-bit).

#

note that I am deploying the app to my organisation through Teams administration rather than through "Upload an app" in the teams client

Perhaps this might be the cause of this issue?

axelsrz commented 2 years ago

Hello @catmanjan in order to proceed with the ticket, could you please provide an update regarding this message?

Hi @catmanjan

After publishing the bot to azure, it seems I'm not able to reproduce this issue.

It gives the option to log in with a username and password and not 6 digit code. Note, I uploaded the manifest.zip to Teams (in the Apps view click "Upload a custom app")

Using Teams Version 1.5.00.17971 (64-bit).

note that I am deploying the app to my organisation through Teams administration rather than through "Upload an app" in the teams client

Perhaps this might be the cause of this issue?

catmanjan commented 2 years ago

@axelsrz sure, what update do you need? I explained my reproduction steps in detail above

munozemilio commented 2 years ago

@catmanjan are you getting the same issue if you upload the manifest.zip to Teams (in the Apps view click "Upload a custom app")

catmanjan commented 2 years ago

No I only saw the issue when deploying the app to the organisation

On Thu, 11 Aug 2022 at 7:31 am, Emilio Munoz @.***> wrote:

@catmanjan https://github.com/catmanjan are you getting the same issue if you upload the manifest.zip to Teams (in the Apps view click "Upload a custom app")

— Reply to this email directly, view it on GitHub https://github.com/microsoft/BotBuilder-Samples/issues/3779#issuecomment-1211298049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBRBUKZAZYQJ7GEMD3MDTVYQNSVANCNFSM5ZHM3R3Q . You are receiving this because you were mentioned.Message ID: @.***>

breakingram commented 2 years ago

Hi @catmanjan,

Looks like uploading the bot to Teams using Microsoft Teams admin center (https://admin.microsoft.com/) is the root cause of this issue.

I'm Investigating further for the next steps.

catmanjan commented 2 years ago

Thanks we're still invested in getting this fixed

breakingram commented 2 years ago

Hi @catmanjan,

The "Microsoft Teams" team was also not able to reproduce this issue using Teams admin center.

From Teams:

It did not ask for 6 digit secret. It logged in with mail Id and password.

Attaching screenshot for reference: MicrosoftTeams-image

MicrosoftTeams-image (1)

breakingram commented 2 years ago

Closing this issue as we are not able to repro.

catmanjan commented 2 years ago

Hello we are still able to reproduce this consistently for new users who have never authenticated with the bot via the web version of Teams, can you please try reproducing this with a brand new test user in your tenant?