search

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.33k stars 4.86k forks source link

SSO Samples for Python #3829

Open vijaysaimutyala opened 1 year ago

vijaysaimutyala commented 1 year ago

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe. So I've been trying to implement SSO on Teams using the Python Bot Framework SDK without much success. The reason is that we wanted to login the users before we let them use the bot on Teams. It might look like an additional step, but with Python not supporting Single Tenancy, this is the only option to secure the bot in case the App ID gets compromised. I was trying to replicate the SSO sample from dotnet but some of the methods are not implemented in the Python SDK if I'm not wrong. As per my research and according to docs, Python currently does not support Single Sign On.

Describe the solution you'd like I would like to see a Teams SSO Sample for Python SDK

Describe alternatives you've considered For now, I'll be going with the OAuth.

faniereynders commented 8 months ago

I am having the same issue. Even with the latest version, it seams SSO does not work the same way .NET is using the Python SDK. SSO works with Python via the web channel, but via Teams it just does not respond.

Error:

response = response or ResourceResponse(activity.id or "")
TypeError: __init__() takes 1 positional argument but 2 were given

This is running the standard Bot Authentication MS Graph sample

@tracyboehrer Do you have any idea? It is blocking.

MariusFearn commented 7 months ago

I have the same issue, code works fine for all but teams - just no response