Archived sample code teams-start-thread-in-channel not working anymore start from Jun 10th

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!

https://github.com/Microsoft/botframework

MIT License

4.36k stars 4.87k forks source link

Archived sample code teams-start-thread-in-channel not working anymore start from Jun 10th #3993

Open rollingstarky opened 3 months ago

rollingstarky commented 3 months ago

Is your feature request related to a problem? Please describe. I have created a Teams Channel Bot two years ago based on this sample code https://github.com/microsoft/BotBuilder-Samples/tree/main/archive/samples/python/58.teams-start-thread-in-channel It's been woking well until Jun 11th this year. I saw this sample has been moved to archive, based on the readme, it's kind of deprecated and no longer working anymore? May I know how this update happen, the exact affects and what I need to do to keep it working?

Describe the solution you'd like Can I bring it back with least changes on current codes

Describe alternatives you've considered Are there any solutions ready that I can migrate current Bot to make it working

Additional context I tried to deploy this one https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-initiate-thread-in-channel/python but it's not working either

rollingstarky commented 3 months ago

I have done some testing and finally found the root cause:

Seems start from Jun 11th, all messages sent to the Teams channel won't be captured by the Bot, unless you type @bot_name in front of the message. That is to say, tag the Bot first then send some messages.
Also message contents the Bot captured is now HTML format, while before Jun 11th, it's plain text.
I have some filters in my Bot project to ignore non-related messages, since the message format changed from plain text to HTML, I can't get any response at all because the filters denied them, even though I added the "@bot_name". That's why I didn't find the root cause at first place

rollingstarky commented 3 months ago

Then I have another three questions:

Is the "@bot_name" mandatory for all future Channel Bots or it can be controlled by some configurations? Like I disable some options and then "@bot_name" not required any more
Same as first question, can I change some options to make the messages Bot captured from HTML format to plain text?
Should I worry about that my Bot will be deprecated very soon

rollingstarky commented 3 months ago

Weird. Today it's switched back again. "@bot_name" not requried anymore, the messages Bot captured also changed back from HTML format to plain text. So I doubt Teams development side mixed something up, wrongly merged interaction logic from outgoing webhook to Bots, then they rolled it back today. Not confirmed, just my doubts.

tracyboehrer commented 3 months ago

@rollingstarky We really don't support things in the Archived folders. I'm tempted to just delete all those since it just causes confusion. For Teams samples, support would have to come from them. I can't even say which ones they've changed, and how, since we moved all those to Teams.