search

microsoft / BotFramework-Composer

Dialog creation and management for Microsoft Bot Framework Applications
https://docs.microsoft.com/en-us/composer/
MIT License
869 stars 372 forks source link

Set properties panel height is not fit #7300

Closed rvinothrajendran closed 7 months ago

rvinothrajendran commented 3 years ago

Describe the bug

Set properties panel height is not fit ex : defined properties "dialog.username = @username" but in the visual canvas "g" is not display properly.

Version

Version: 1.4.0-nightly.238265.5106247 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0

Browser

OS

To Reproduce

Steps to reproduce the behavior:

Add the properties in the Set Properties panel ... "g" is not visible properly.

Expected behavior

All the letters should be visible

Screenshots

prop

Additional context

GeoffCoxMSFT commented 3 years ago

I can't reproduce this, but I was looking at the line-height property, it is showing invalid.

image

image

I see this style in styledComponents.ts which is the only place a line-height is calculated. There are some cases where the props being applied cause height to be an object.

export const SingleLineDiv = styled.div ${StandardFontCSS}; ${TruncatedCSS}; line-height: ${(height) => (height ? height + 'px' : undefined)}; ;

GeoffCoxMSFT commented 3 years ago

@rvinothrajendran I think this invalid line-height issue is causing the overlap you are seeing.

tsuwandy commented 3 years ago

Will be fixed with the next release.

OEvgeny commented 7 months ago

Looks like it is fixed (can't reproduce)