search

microsoft / BotFramework-Composer

Dialog creation and management for Microsoft Bot Framework Applications
https://docs.microsoft.com/en-us/composer/
MIT License
870 stars 372 forks source link

Upgrade recoil to 0.3 #7853

Open srinaath opened 3 years ago

srinaath commented 3 years ago

Composer main is currently based on an older version of Recoil (0.0.13). This task encapsulates the work required to upgrade Composer to use recoil 0.3 and handle changes to code required and test all scenarios in the electron installer.

boydc2014 commented 3 years ago

@lei9444 is this something you can take a look?

lei9444 commented 3 years ago

I have done some investigation on it. There will be a break change about the snapshot if we want to use it in async function (in 0.3.0 will console warning only).

The change is like image we need to manually retain and then release the snapshot.

Today, we use a lot of snapshot in our dispatcher, so this may take some time to update and need to test all workflows to make sure it work.

boydc2014 commented 3 years ago

Let's move this out R14 for now given the assessment is this is a big breaking change.