microsoft / BotFramework-Composer

Dialog creation and management for Microsoft Bot Framework Applications
https://docs.microsoft.com/en-us/composer/
MIT License
867 stars 369 forks source link

Published skill's manifest fails validation when added in PVA #8546

Open stevkan opened 3 years ago

stevkan commented 3 years ago

Describe the bug

When attempting to add a published skill to PVA via the "Add skill" option, the linked manifest fails the validation test

Version

2.1.0-nightly.263368.d67aa4c

Browser

OS

To Reproduce

Steps to reproduce the behavior:

  1. Create a Power Virtual Agent
  2. Navigate to Manage => Skills
  3. Click and copy value in Provide ID for allow list
  4. Create a bot in Composer
  5. Navigate to Configure => Skill configuration
  6. Add copied ID to Allowed Callers
  7. Publish bot
  8. Navigate to Publish and click Copy Skill Manifest URL
  9. In PVA, click Add skill, paste in manifest URL, and click Next
  10. Observe failed validation

Expected behavior

The manifest should validate making the Composer bot accessible as a skill.

Screenshots

image

Additional context

{
  "$schema": "https://schemas.botframework.com/schemas/skills/v2.2/skill-manifest.json",
  "$id": "Empty_Bot_0-c91756de-xxxx-xxxx-xxxx-59c804878d2c",
  "endpoints": [
    {
      "protocol": "BotFrameworkV3",
      "name": "x-xxxxx-empty-bot",
      "endpointUrl": "https://x-xxxxx-empty-bot.azurewebsites.net/api/messages",
      "description": "<description>",
      "msAppId": "11c16026-xxxx-xxxx-xxxx-32e7fbd1e33d"
    }
  ],
  "name": "Empty_Bot_0",
  "version": "1.0",
  "publisherName": "Steven K.",
  "activities": {
    "Empty_Bot_0": {
      "type": "event",
      "name": "Empty_Bot_0"
    },
    "AttachmentDialog": {
      "type": "event",
      "name": "AttachmentDialog"
    },
    "Switch_Dialog": {
      "type": "event",
      "name": "Switch_Dialog"
    },
    "conversationUpdate": {
      "type": "conversationUpdate"
    },
    "message": {
      "type": "message"
    },
    "typing": {
      "type": "typing"
    }
  },
  "dispatchModels": {
    "languages": {
      "en-us": [
        {
          "name": "Empty_Bot_0",
          "contentType": "application/lu",
          "url": "https://x-xxxxx-empty-bot.azurewebsites.net/manifests/skill-Empty_Bot_0.en-us.lu",
          "description": "<description>"
        }
      ]
    },
    "intents": [
      "AskForAttachment",
      "Switch_trigger"
    ]
  }
}
tonyanziano commented 3 years ago

@sbacha is there anything here that stands out to you?

ryub3n commented 2 years ago

@stevkan / @tonyanziano , I'm facing this issue too