microsoft / BotFramework-Composer

Dialog creation and management for Microsoft Bot Framework Applications
https://docs.microsoft.com/en-us/composer/
MIT License
860 stars 366 forks source link

fix: [#9666] Onclick Insert property reference in a memory drop down not appearing in Bot Framework Composer 2.1.3. #9678

Closed JhontSouth closed 5 months ago

JhontSouth commented 6 months ago

Description

This PR adds the CSRF token in the headers of the fetch request of the project memory variables.

Task Item

Fixes #9666

Screenshots

The following image shows the references dropdown working after the fix. image

tracyboehrer commented 6 months ago
image
tracyboehrer commented 6 months ago

Build error "The lockfile would have been modified by this install, which is explicitly forbidden."

JhontSouth commented 6 months ago

Build error "The lockfile would have been modified by this install, which is explicitly forbidden."

Thank you Tracy, we are reviewing it.

tracyboehrer commented 6 months ago

Summary of all failing tests FAIL packages/client/tests/pages/language-generation/LGPage.test.tsx ● LG page all up view › should render lg page code editor

TypeError: Cannot read property 'cancel' of undefined

  102 |     // clean up pending async request
  103 |     return () => {
> 104 |       source.cancel();
      |              ^
  105 |     };
  106 |   }, [projectId]);
  107 |

  at src/pages/language-generation/code-editor.tsx:104:14
  at HTMLUnknownElement.callCallback (../../node_modules/react-dom/cjs/react-dom.development.js:188:14)
  at HTMLUnknownElement.callTheUserObjectsOperation (../../node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
  at innerInvokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:338:25)
  at invokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
  at HTMLUnknownElementImpl._dispatch (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
  at HTMLUnknownElementImpl.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
  at HTMLUnknownElement.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
  at Object.invokeGuardedCallbackDev (../../node_modules/react-dom/cjs/react-dom.development.js:237:16)
  at invokeGuardedCallback (../../node_modules/react-dom/cjs/react-dom.development.js:292:31)
  at safelyCallDestroy (../../node_modules/react-dom/cjs/react-dom.development.js:19617:5)
  at ../../node_modules/react-dom/cjs/react-dom.development.js:20090:21
  at unstable_runWithPriority (../../node_modules/scheduler/cjs/scheduler.development.js:653:12)
  at runWithPriority$1 (../../node_modules/react-dom/cjs/react-dom.development.js:11039:10)
  at commitUnmount (../../node_modules/react-dom/cjs/react-dom.development.js:20083:15)
  at unmountHostComponents (../../node_modules/react-dom/cjs/react-dom.development.js:20464:7)
  at commitDeletion (../../node_modules/react-dom/cjs/react-dom.development.js:20500:5)
  at commitMutationEffects (../../node_modules/react-dom/cjs/react-dom.development.js:22782:11)
  at HTMLUnknownElement.callCallback (../../node_modules/react-dom/cjs/react-dom.development.js:188:14)
  at HTMLUnknownElement.callTheUserObjectsOperation (../../node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
  at innerInvokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:338:25)
  at invokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
  at HTMLUnknownElementImpl._dispatch (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
  at HTMLUnknownElementImpl.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
  at HTMLUnknownElement.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
  at Object.invokeGuardedCallbackDev (../../node_modules/react-dom/cjs/react-dom.development.js:237:16)
  at invokeGuardedCallback (../../node_modules/react-dom/cjs/react-dom.development.js:292:31)
  at commitRootImpl (../../node_modules/react-dom/cjs/react-dom.development.js:22509:9)
  at unstable_runWithPriority (../../node_modules/scheduler/cjs/scheduler.development.js:653:12)
  at runWithPriority$1 (../../node_modules/react-dom/cjs/react-dom.development.js:11039:10)
  at commitRoot (../../node_modules/react-dom/cjs/react-dom.development.js:22381:3)
  at finishSyncRender (../../node_modules/react-dom/cjs/react-dom.development.js:21807:3)
  at performSyncWorkOnRoot (../../node_modules/react-dom/cjs/react-dom.development.js:21793:7)
  at scheduleUpdateOnFiber (../../node_modules/react-dom/cjs/react-dom.development.js:21188:7)
  at updateContainer (../../node_modules/react-dom/cjs/react-dom.development.js:24373:3)
  at legacyRenderSubtreeIntoContainer (../../node_modules/react-dom/cjs/react-dom.development.js:2[477](https://github.com/microsoft/BotFramework-Composer/actions/runs/7264840533/job/19795205920?pr=9678#step:9:478)4:5)
  at ../../node_modules/react-dom/cjs/react-dom.development.js:2[488](https://github.com/microsoft/BotFramework-Composer/actions/runs/7264840533/job/19795205920?pr=9678#step:9:489)4:7
  at unbatchedUpdates (../../node_modules/react-dom/cjs/react-dom.development.js:21903:12)
  at Object.unmountComponentAtNode (../../node_modules/react-dom/cjs/react-dom.development.js:24883:5)
  at ../../node_modules/@testing-library/react/dist/pure.js:144:23
  at batchedUpdates$1 (../../node_modules/react-dom/cjs/react-dom.development.js:21856:12)
  at act (../../node_modules/react-dom/cjs/react-dom-test-utils.development.js:929:14)
  at cleanupAtContainer (../../node_modules/@testing-library/react/dist/pure.js:143:26)
      at Set.forEach (<anonymous>)
  at cleanup (../../node_modules/@testing-library/react/dist/pure.js:137:21)
  at Object.<anonymous> (../../node_modules/@testing-library/react/dist/index.js:33:25)
coveralls commented 6 months ago

Coverage Status

coverage: 54.482% (-0.008%) from 54.49% when pulling 2fa312fbea9a79b90177640e2d374f32b3bf0de1 on southworks/fix/enable-references-dropdown into 1a93f21d169534d123dd582a24467c5dafd09543 on main.

JhontSouth commented 6 months ago

@tracyboehrer , @OEvgeny We reverted the axios updates and kept the fetch request, but now we're using the CSRF token in the request headers. The PR is ready for review now.