search

microsoft / BotFramework-DirectLineJS

JavaScript client library for Microsoft Bot Framework's Direct Line protocol
MIT License
195 stars 127 forks source link

rxjs - peer dependency #178

Open cheng93 opened 5 years ago

cheng93 commented 5 years ago

rxjs should be specified as a peer dependency.

This will allow users to use rxjs6 with rxjs-compat.

Currently I get errors such as 

Type 'import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/node_modules/rxjs/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>' is not assignable to type 'import("c:/Code/AngularWebComponents/node_modules/rxjs/internal/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>'.
cwhitten commented 3 years ago

Loading up for discussion/prioritization in an upcoming release

Dan-scheiner-simpligov commented 11 months ago

Hi @cwhitten, was this resolved? Looks like rxjs 5.5.12 is still being used and I'm experiencing the issue above. Do you have plans to upgrade rxjs?