search

microsoft / BotFramework-Emulator

A desktop application that allows users to locally test and debug chat bots built with the Bot Framework SDK.
https://aka.ms/botemulator
MIT License
1.81k stars 753 forks source link

Emulator does not render valid adaptive card in an activity #2154

Closed chrimc62 closed 6 months ago

chrimc62 commented 4 years ago

Version of emulator: 4.9.1

The below activity has a valid adaptive card that renders properly in adaptivecards.io. In emulator it looks like the below. It seems related to having a curly bracest in the string value. If I change it to obj= and remove the trailing curly brace it works fine.

In emulator (wrong): image

In adaptive cards designer (right): image

Activity:

{
    "type": "message",
    "attachments": [
        {
            "contentType": "application/vnd.microsoft.card.adaptive",
            "content": {
                "type": "AdaptiveCard",
                "version": "1.0",
                "body": [
                    {
                        "type": "TextBlock",
                        "text": "simple",
                        "size": "large"
                    },
                    {
                        "type": "FactSet",
                        "facts": [
                            {
                                "title": "due",
                                "value": "{timex: [2020-06-01], type: date}"
                            }
                        ]
                    }
                ],
                "$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
            }
        }
    ]
}
tonyanziano commented 4 years ago

We should test this in Web Chat.

stevkan commented 4 years ago

Possibly related to Web Chat bug #3165

chrimc62 commented 4 years ago

This is still an issue. This: image Renders as this: image

tonyanziano commented 4 years ago

I just tested this with the latest Web Chat and the bug is still present in 4.10.0.

The issue (https://github.com/microsoft/BotFramework-WebChat/issues/3165) has been labeled for R11 and can be tracked there.

chrimc62 commented 3 years ago

This was not fixed in R11 or R12. Is it ever going to be fixed?

tonyanziano commented 3 years ago

@chrimc62 this is a Web Chat bug so it will be present in Emulator until it is fixed in Web Chat. If you look at https://github.com/microsoft/BotFramework-WebChat/issues/3165 you can see that it was moved into the R13 milestone last week.

corinagum commented 3 years ago

In progress now - sorry @chrimc62 for the wait. Low on manpower haha.

amazingYolk commented 2 years ago

Still not fixed in version 4.14.1 of emulator, how's it going?

amazingYolk commented 2 years ago

Still not fixed in version 4.14.1 of emulator, how's it going?

image