fix: auth flow issues - Githubissues

microsoft / BotFramework-Emulator

A desktop application that allows users to locally test and debug chat bots built with the Bot Framework SDK.

https://aka.ms/botemulator

MIT License

1.81k stars 752 forks source link

fix: auth flow issues #2417

Closed OEvgeny closed 1 year ago

OEvgeny commented 1 year ago

This fixes the following auth flow issues:

Race condition caused by delayed subscription to navigation events causes auth proccess to silently stuck
Potentially vulnerable URL parsing logic
Possible identity spoofing/theft caused by the race condition

coveralls commented 1 year ago

Coverage: 67.69%. Remained the same when pulling bb7fe31003650b99bf26aeed68ddde2a49e4aef5 on OEvgeny:fix/auth-flow into 1e5f36fc4be60c5016dbf21cdac1aa569ab18373 on microsoft:main.

OEvgeny commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).