search

microsoft / BotFramework-Emulator

A desktop application that allows users to locally test and debug chat bots built with the Bot Framework SDK.
https://aka.ms/botemulator
MIT License
1.79k stars 748 forks source link

fix: [#2398] Support Bots that use Single Tenant AAD Applications #2457

Closed ceciliaavila closed 1 month ago

ceciliaavila commented 3 months ago

Fixes #2398

Description

This PR enables the tenant id value to authenticate Emulator with Single Tenant apps.

This feature requires bots with the last updates of botbuilder-dotnet and botbuilder-js: PR#6769 PR#4643

Specific Changes

Testing

These images show the new field Tenant ID in the Open Bot and New Bot Configuration views. image image

This is the new message error related to authentication. image

The following image shows the Emulator working with a bot using Single Tenant authentication. image

coveralls commented 3 months ago

Coverage Status

coverage: 67.547% (-0.004%) from 67.551% when pulling c804d815a6256c664dcbbd447a73c1155a4ef7c3 on southworks/add/support-singletenant-apps into 012a6641077fe96c8155687f8e6ecb1ebffdc0e3 on main.

GaryIrick commented 1 month ago

@tracyboehrer is there anywhere I can get a build of the emulator with this PR in it? The nightlies repo doesn't have any recent builds. I could build it myself, looking to avoid the time spent getting all of the build tools stood up so I can focus on testing a bot. I'm hoping this exists and I just missed it.

Thanks!

tracyboehrer commented 1 month ago

@GaryIrick At the moment there isn't. This also relies on a change on the SDK side to take the tenant into account when validating the token. That has just now made it to the DotNet SDK.