microsoft / BotFramework-Emulator

A desktop application that allows users to locally test and debug chat bots built with the Bot Framework SDK.
https://aka.ms/botemulator
MIT License
1.81k stars 754 forks source link

Install CLI tools with V4 Emulator install #771

Open vishwacsena opened 6 years ago

sgellock commented 6 years ago

Let's consider adding an "Install Commandline Tools" menu option to install the CLI tools. We can also see if we can then leverage autoupdate for CLI as well as the core emulator

vishwacsena commented 6 years ago

Three separate work items here -

  1. Add a "Install command line tools" menu option that presents a modal with information on what the CLI tools are and link to docs with a checkbox to 'auto update command line tools'. Clicking ok/ install in this dialog should install all cli tools. Should prompt user to install node and try again if node is not installed.
  2. Have auto update checker also look for presence of CLI tool and if found and if auto-update is turned on for CLI tools, update them as well.
  3. 'Auto update command line tools' setting is manageable via emulator settings page.
justinwilaby commented 5 years ago

To implement this, we can use a custom script and the technique described here.

sgellock commented 5 years ago

Does this approach work on non windows OS’s?

From: Justin Wilaby notifications@github.com Reply-To: Microsoft/BotFramework-Emulator reply@reply.github.com Date: Monday, January 7, 2019 at 6:34 AM To: Microsoft/BotFramework-Emulator BotFramework-Emulator@noreply.github.com Cc: Scott Gellock Scott.Gellock@microsoft.com, Comment comment@noreply.github.com Subject: Re: [Microsoft/BotFramework-Emulator] Install CLI tools with V4 Emulator install (#771)

To implement this, we can use a custom scripthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.electron.build%2Fconfiguration%2Fnsis%23custom-nsis-script&data=02%7C01%7Cscott.gellock%40microsoft.com%7Ca29300bda13344cd381e08d674ad3f47%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636824684771476441&sdata=jw1CIDYP1v45wpqWXq%2BTY6XI85BGL6PqyH7P6uMTHs8%3D&reserved=0 and the technique described herehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fquestions%2F42277191%2Fadd-nsis-script-with-electron-builder-to-run-dpinst-exe-during-install&data=02%7C01%7Cscott.gellock%40microsoft.com%7Ca29300bda13344cd381e08d674ad3f47%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636824684771486446&sdata=UiVsrGQ0Ef8ci3gRT3mu2Oc1pMvpmnMvaOdts9%2Fs2k0%3D&reserved=0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBotFramework-Emulator%2Fissues%2F771%23issuecomment-451953829&data=02%7C01%7Cscott.gellock%40microsoft.com%7Ca29300bda13344cd381e08d674ad3f47%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636824684771486446&sdata=VbBjxYLfHIdqi4zDXf3tc7%2FX9eraMNZ9jTMc4nLOPxE%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAsxd0Xji1psaWidfEqUHmNm_W_AmxkQks5vA1r6gaJpZM4V_El3&data=02%7C01%7Cscott.gellock%40microsoft.com%7Ca29300bda13344cd381e08d674ad3f47%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636824684771496450&sdata=5i1ukbYKsKxAGhwHlDp8Va%2FNJu8ZNjxce5VAzrylPPw%3D&reserved=0.

mewa1024 commented 5 years ago

UI CHANGES - one menu item and 2 modals

Menu item:

Add menu item to Help menu below "Check for update..." and in the same section. In other words, here: image

Menu item text should be "Install command line tools ...". This opens the "Install command line tools" modal.

--

"Install command line tools" modal:

[title] Install command line tools

[paragraph] Bot Builder tools are a collection of cross-platform command line tools designed to cover end-to-end bot development workflow. Learn more. ["Learn more" text is a link to https://github.com/Microsoft/botbuilder-tools ]

[checkbox item, initially unchecked] [ ] Automatically update command line tools

[buttons] Cancel [secondary] Install now [primary]

If node is not installed, show the next modal.

-- "Node.js" modal

[title] Install node.js

[paragraph] Node.js version 8.5 or higher is required for the command line tools. Please install node.js and try again. [Node.js is a link to https://nodejs.org/ ]

[button] Close [primary]

--