Microsoft Teams deltas and added features

[billbliss]

Let me know how I might factor this differently.

[msftclas]

@billbliss, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

[billbliss]

I didn't mention the rationale for the edit on line 55. I deleted the "cb" parameter because it was not referenced anywhere in the code.

[maxpert]

I made some changes over the weekend for middle-ware. I still need to test them but so far I can see lots of channel specific parts can be moved to middle-wares. I am not sure however on if it's a good idea to have an adapter that can further have middle-wares. It's like saying adapter having adapters 😛

[billbliss]

Zohaib, I have integrated my branch with your changes.

• adapter.coffee should be exactly the same as your most recent version. But since there was a merge conflict, I had to submit a new version of the file.
• msteams-middleware.coffee has not changed and works the same way as it did before and plugs into Hubot middleware.
• middlewares.coffee incorporates all the changes I couldn't originally factor out of adapter.coffee. There are three significant deltas from your version:
  • Adding the Microsoft Teams tenant id to the robot.brain entry in TextMiddleware. Without replacing your middleware with a completely different version I wasn't sure how to factor this. That is, once your middleware writes the entry, I can't add another middleware to write another one. The change should not affect other channels.
  • Changing the @mentions to match Teams semantics. This one might be factor-able, but I wasn't sure.
  • Handling the special case of when the text response contains a URL - adding it to the attachments array. I think that's generally useful across all the BF channels.
  • There are a few helper functions I added. If there's a cleaner way of adding those, let me know.

[billbliss]

Zohaib,

I spent the holiday weekend making the changes you suggested as well as a few other things to clean it up:

• Renamed LICENSE to LICENSE.md which is the standard naming convention for license documents. Also moved the redundant MIT license from the source and added "Licensed under the MIT license" comments, following CELA OSS standards.
• Fixed a typo in package.json
• Renamed "middlewares.coffee" to "adapter-middleware.coffee" to distinguish between Hubot middleware and this. Also renamed middlewares to middleware (proper English)
• Reduced the imports from adapter-middleware (formerly middlewares) - only the middlewareFor method is needed
• Added a comment and a commented-out line to make it easy to activate MS Teams middleware. I tried doing an include of it instead as a script, as you suggested, but then you get an error during the build process because the Hubot script loader expects functions, not class definitions. This is a non-invasive change IMO.
• Fixed the middleware invocation logic in adapter.coffee - you were using channelId but it needs to be activity.source
• Minor change to error handling syntax in reply: method in adapter.coffee to make it easier to add real error handling later
• msteams-middleware.coffee is structured as you suggested - thanks. I haven't refactored the Hubot middleware into toSendable middleware though because I'm having some problems (unrelated) with being throttled when submitting multiple messages, so I want to get to the bottom of that first.

[billbliss]

Merge conflicts resolved.

[msftclas]

@billbliss, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot