microsoft / BotFramework-Hubot

Hubot adapter for botframework
MIT License
111 stars 40 forks source link

Refactor the middleware send() function to not break the middleware abstraction #33

Open MSMeMend opened 6 years ago

MSMeMend commented 6 years ago

Middleware is meant to act as an in between converter between Bot Framework and hubot entities. PR #29 adds a middleware.send() method in order to be able to handle aggregating multiple hubot responses into one Bot Framework response, but this should be changed to move sending to Bot Framework into the main adapter to maintain proper middleware abstraction.