search

microsoft / BotFramework-Hubot

Hubot adapter for botframework
MIT License
111 stars 40 forks source link

Adds support for Skype through MicrosoftSkypeMiddleware #36

Closed leonardochaia closed 6 years ago

leonardochaia commented 6 years ago

Adds the MicrosoftSkypeMiddleware, which is the same as the MicrosoftTeamsMiddleware but with less features.

Features included:

  1. Typing indicator support
  2. Properly handles chat vs. channel messages
  3. Properly handles image responses.

Features removed:

  1. Slack mentions convertion
  2. HUBOT_OFFICE365_TENANT_FILTER

Given that the logic below Helper methods for generating richer messages (line 70) is exactly the same as MicrosoftTeamsMiddleware we could refactor to reuse it, but considering that, despite of being the same, they're specific to the channel they represent so we may decide to leave it as it is. Do let me know if you'd like to share this logic and I'll refactor.

Fixes #31

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.6%) to 91.728% when pulling 8abb71cb41d099e8df2ad56fc5b3c0482690b936 on leonardochaia:features/support-skype into 342cb8cad6b82076491c54fb960899f1c7df892e on Microsoft:master.

MatSFT commented 6 years ago

Just call it the SkypeMiddleware. The Teams one is called MicrosoftTeamsMiddleware because that's technically the full product name.

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

leonardochaia commented 6 years ago

@MattSFT done, renamed MicrosoftSkypeMiddleware to SkypeMiddleware

MatSFT commented 6 years ago

@leonardochaia are you planning to merge this in?

leonardochaia commented 6 years ago

Hi @MattSFT, it'd be great to merge this, but I don't think I'm allowed to:

Only those with write access to this repository can merge pull requests.