search

microsoft / BotFramework-Services

Microsoft Bot Framework Services
Creative Commons Attribution 4.0 International
38 stars 11 forks source link

Cannot save bot: `Please correct the errors and try again.' #328

Closed fabiank0 closed 2 years ago

fabiank0 commented 2 years ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

No SDK, dev.botframework.com

Describe the bug

Bug: Settings in the dev.botframework.com page cannot be changed, leading to an error.

C.f. the discussion in the closed issue https://github.com/microsoft/botframework-sdk/issues/3549 I've decided to open a new issue since the original issue was about a different problem.

As has been pointed out in the discussion above, the problem lies in the property 'MsaAppType':'0' that is being sent with the request, leading to the error {"Errors":[{"Field":"MsaAppType","Message":"'MsaAppType' property cannot be changed."}]}

To Reproduce

Steps to reproduce the behavior:

  1. Go to dev.botframework.com
  2. change something
  3. press save changes
  4. See error: Please correct the errors and try again

Expected behavior

Saving succeeds successfully.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Tracking Status

Dotnet SDK [TODO]()

Javascript SDK [TODO]()

Python SDK [TODO]()

Java SDK [TODO]()

Samples [TODO]()

Docs [TODO]()

Tools [TODO]()

anishprasad01 commented 2 years ago

Hi @fabiank0,

In most cases, functions in from the older dev.botframework.com are now found in the Azure Portal. In most cases, the site should redirect you to Azure anyway.

Could you perhaps provide more info about the bot you're trying to edit, what information you can access on dev.botframework.com, and what settings you're trying to edit?

Additionally, can you successfully make these changes on the Azure Portal?

fabiank0 commented 2 years ago

Hi @anishprasad01 For me the setting in question is the `Messaging endpoint', though I'm not sure if the others were trying to change some other setting.

I've always used the dev.botframework.com site, and I was not aware that there's been a change. I tried to look for this service in Azure Portal, but I was not able to find it.

anishprasad01 commented 2 years ago

@fabiank0

Could I get your bot's AppID (not the password)? You can send it to me directly via my work email on my profile if you'd feel more comfortable. Please mention this issue in your email.

anishprasad01 commented 2 years ago

Closing this issue due to inactivity. If you still require assistance, please comment and we can reopen the issue.

MatDumoulin commented 2 years ago

Hi @anishprasad01 ,

I'm having the exact same issue as @fabiank0 with dev.botframework.com. I will provide the needed information in order to make this case move forward.

We currently have many bots and all of them are having the "Please correct the errors and try again" issue in the botframework website. They were all created around the same time through the Teams AppStudio application. image

I sent you the Application Id of one of my bot on your work email.

I also checked in Azure for resources related to my bots and the only things I can find are AAD App Registrations for them. image

App Registrations do not offer the possibility to change the messaging endpoint of a bot. Is there a ressource missing in Azure?

anishprasad01 commented 2 years ago

@MatDumoulin

Thank you for the report. We are investigating.

MatDumoulin commented 2 years ago

Hi there!

To follow up on the issue, I think we found why the "Please correct the errors and try again." error was occuring. Through Microsoft documentation, we found that https://dev.botframework.com/ is not the official way of managing your bots anymore.

The fix for us was to migrate our bots to Azure. Once the migration is done, you can change the messaging endpoint directly in Azure instead of doing it through dev.botframework.com.

I hope others might find this information useful!

As a side note, the documentation has to be updated since our bots are only using the Microsoft Teams channel but they still needed to be migrated.

anishprasad01 commented 2 years ago

@MatDumoulin

We are working on getting that error resolved, but in the long-term migrating to Azure is the best bet and a good workaround.

As a side note, the documentation has to be updated since our bots are only using the Microsoft Teams channel but they still needed to be migrated.

I don't understand what you mean by this. Migrating a bot to Azure happens irrespective of channel.

MatDumoulin commented 2 years ago

I was referring to the following sentence in the documentation: image

False alarm though. The documentation is correct taking into account that you are working to resolve the error in https://dev.botframework.com/ instead of encouraging developers to migrate their bots.

Thank you @anishprasad01

bobokids commented 2 years ago

We had a PR ready for this issue. Incident 284309614 : [PR Ready]Need a fix: Cannot save bots in Dev Portal

fabiank0 commented 2 years ago

Thanks @MatDumoulin. @anishprasad01 Do you still need an App ID of a Bot?

anishprasad01 commented 2 years ago

Nope, we're good. Once the PR makes its way through and goes live, the problem should be fixed and we'll close this issue.

cosmicshuai commented 2 years ago

I have a PR fix this issue.

anishprasad01 commented 2 years ago

@fabiank0, @MatDumoulin,

The fix is live. Could you please retry and ensure that the bug is not still present?

fabiank0 commented 2 years ago

@anishprasad01 I can confirm that it works for me now. Thank you very much.