microsoft / BotFramework-Services

Microsoft Bot Framework Services
Creative Commons Attribution 4.0 International
38 stars 11 forks source link

Unable to upload Microsoft Excel sheet in Slack Channel #334

Closed RamkumarManavalan closed 2 years ago

RamkumarManavalan commented 2 years ago

Details of the Composer version I use:

I use the "File or Attachment" option to accept files from users in Slack. Every other common file types work, except for Microsoft Excel/Word files. The "File or Attachment" does not return any result back, but shows a preview of the file properly. Please see the picture below.

slack-file-attachment-error

Any help in resolving this? Thanks.

stevkan commented 2 years ago

@RamkumarManavalan, at the moment I am unable to repro the issue. To be clear, are you using the Slack adapter package, found in the Package Manager, in your Composer bot? Also, what is the size of the Excel document that you are trying to send?

RamkumarManavalan commented 2 years ago

No, I have not used slack adapter. I created a slack app and used its credentials to configure in the bot's slack channel configuration in azure portal.

The size is of KBs (less tha 500 KB).

stevkan commented 2 years ago

@RamkumarManavalan, apologies to you as it seems I misread your initial post. Based on your description, I am now able to repro the issue. Looking at the activity with an attached Excel file, it appears that the activity.attachments property is not populating with the files contentType, contentUrl, and name properties. As you can see in the attached image, the activity with an attached JSON file is structured correctly whereas the Excel attachment is not:

image

image

I am able to repro the issue in both a C# Composer bot as well as in a code-first JS bot. The activity, including the attachments property, is constructed in the Slack channel connector as the incoming Slack message arrives. This bug will need to be addressed by our Services team.

@Services team, can someone please investigate this further?

RamkumarManavalan commented 2 years ago

Thank you so much @stevkan.

Please keep this thread posted on which release this bug is planned to be fixed as part of.

RamkumarManavalan commented 2 years ago

Any update on this, team? We are totally blocked on this.

ssss141414 commented 2 years ago

Hi @RamkumarManavalan , I'm working on fixing this issue. Sorry for keeping you waiting.

And according to Steven's reply, before our fix is onboard, you can temporarily use properties in Activity.ChannelData.files to download the files.

ssss141414 commented 2 years ago

The fix will be onboard next week.

RamkumarManavalan commented 2 years ago

Glad to hear. Thank you so much.

RamkumarManavalan commented 2 years ago

@ssss141414 , has this fix been rolled out to production? If yes, which version of bot framework should I upgrade to?

ssss141414 commented 2 years ago

@RamkumarManavalan Yes the fix has come to Prod. Since the fix is on server side, you don't need to update version. Please have a try to see if the issue persists. Thank you.

bobokids commented 2 years ago

Resolved the issue for now. Please reactivate it if you still get it repro-ed.