Bot Framework Emulator - Audio card -image is not displaying.

microsoft / BotFramework-WebChat

A highly-customizable web-based client for Azure Bot Services.

https://www.botframework.com/

MIT License

1.59k stars 1.54k forks source link

Bot Framework Emulator - Audio card -image is not displaying. #3315

Open rvinothrajendran opened 4 years ago

rvinothrajendran commented 4 years ago

Version

4.9.0

Describe the bug

Audio card -image is not displaying.

Steps to reproduce

Try the Audio Card sample with image.

Expected behavior

Image should be display

Screenshots

v-kydela commented 4 years ago

Thank you for the report, @rvinothrajendran

Would you kindly link to the sample you're referring to, and provide some code that reproduces the issue?

rvinothrajendran commented 4 years ago

@v-kydela Kindly find the sample here : https://github.com/rvinothrajendran/BotTutorialSample/tree/master/Python_tutorial/18-AudioCard/audiocard

v-kydela commented 4 years ago

@compulim - I have confirmed that audio card images do not render in Web Chat or Emulator, and it's not because of the SVG. JPG images also do not render. (This has nothing to do with the bot being written in Python, of course.) I will transfer this to you.

daveta commented 4 years ago

@compulim : Any updates?

peterinnesmsft commented 4 years ago

@compulim are you able to take a look into this one?

compulim commented 4 years ago

I believe this is a feature we missed.

tdurnford commented 4 years ago

@v-kydela Web Chat is equipped to handle Audio Cards with images; however, DirectLineJs is not. https://github.com/microsoft/BotFramework-DirectLineJS/issues/180

tonyanziano commented 4 years ago

So to clarify, @tdurnford, Web Chat currently supports this with Bots connected via DirectLine?

If that's the case, there's basically a lack of parity here between Emulator and Web Chat and the ask would be to implement images with audio cards in the Emulator?

tdurnford commented 4 years ago

@tonyanziano Not quite. If Web Chat receives an Audio Card with an image, it will render the poster correctly. However, if the bot sends an Audio Card with an image and it is sent through DirectLine, DirectLine will remove the image. Web Chat/DirectLineJs and the Emulator current exhibit the same behavior.

Additional Context

https://github.com/microsoft/BotFramework-WebChat/blob/1559ab52158e1b3d0e523d1c2b8b66c462e0494c/packages/bundle/src/adaptiveCards/Attachment/AudioCardContent.js#L21

corinagum commented 3 years ago

I believe this is blocked by https://github.com/microsoft/BotFramework-DirectLineJS/issues/180, confirm? Mark DLJS issue as bug? Assigning to @Kaiqb for visibility

compulim commented 3 years ago

@corinagum this is also related to https://github.com/microsoft/BotFramework-DirectLineJS/issues/255.

carlosscastro commented 3 years ago

@compulim I see that https://github.com/microsoft/BotFramework-DirectLineJS/issues/255 is scheduled to ship on R13. ASsuming that is the case, would this be also addressed in R13?