microsoft / BotFramework-WebChat

A highly-customizable web-based client for Azure Bot Services.
https://www.botframework.com/
MIT License
1.59k stars 1.54k forks source link

[Visual Requirements - BOT Framework - Web Chat > Adaptive Card inputs]: Place holder value is not defined for the 'Time picker' control. #4724

Closed KattaBhargav closed 1 year ago

KattaBhargav commented 1 year ago

User Experience:

Visual users will be impacted if there is no place holder for the control. Person having limited cognitive abilities and dyslexia person cannot easily understand the purpose of the elements if there is no place holder.

Note

User credentials should NOT be included in the bug.

Repro Steps:

  1. Launch URL: https://microsoft.github.io/BotFramework-WebChat/01.getting-started/a.full-bundle/ on edge dev.
  2. Web chat page opens.
  3. Press 4-tab keys to reach 'Type your message' field. Enter the "card input" keyword on it. Press 1-tab key to reach the 'send' button and activate it with the enter key.
  4. Press 2-shift tabs and 1-down arrow to reach the received card.
  5. Verify whether in place holder value is defined for time picker or not.

Actual Result:

Place holder value is not defined for the 'Time picker' control.

Expected Result:

Place holder value should be defined for the 'Time picker' control. Place holder value as 'Time picker' should be defined.

MAS Reference:

MAS 3.3.2 – Labels or Instructions

Reference Links:

Test Environment:

KattaBhargav commented 1 year ago

A11yMAS;#A11ySev3;#HCL;#MAS3.3.2;#Accessibility;#Benchmark;#Win11-Edge(Chromium);#BotFrameworkWebChat-May23;

raviraushanweb commented 1 year ago

image

It is the correct placeholder for the time picker. What change are you expecting?

compulim commented 1 year ago

According to MDN <input placeholder>, placeholder text is not supported by time picker. It is only supported by text, search, url, tel,email,password, andnumber` only.

Despite we already set placeholder in the <input type="time">, browser did not show it. I think this is correct behavior.

image