search

microsoft / BotFramework-WebChat

A highly-customizable web-based client for Azure Bot Services.
https://www.botframework.com/
MIT License
1.58k stars 1.53k forks source link

Citation may not need to use protocol "cite:" #4869

Closed compulim closed 11 months ago

compulim commented 12 months ago

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Development build

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Others or unrelated

Which browsers and platforms do the issue happened?

Others or unrelated

Which area does this issue affect?

Chat history

What is the public URL for the website?

No response

Please describe the bug

Today, citations must be a IRI using protocol cite:. This restriction should be lifted.

Instead, a citation should only be a Schema.org Claim in the entities array, with an @id for an IRI.

Do you see any errors in console log?

No response

How to reproduce the issue?

  1. Handcraft an activity with a citation using protocol abc:
  2. Start conversation
  3. Click on the citation

What do you expect?

The citation modal dialog show show.

What actually happened?

The citation modal dialog is not shown.

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

compulim commented 11 months ago

We probably need to lockdown on a specific protocol prefix because browser could use other protocols to launch native apps.

mamun-131 commented 5 months ago

what should be the JSON structure into turn_context.send_activity to activate pop up modal citation?