Open compulim opened 7 years ago
I'm thinking that we should keep it. Imagine if I was on a mobile device, I would not want to type again.
Here's an alternative (for discussion, I don't actually like it): on "Upload" send the text as well as the attachment.
@DesignPolice @mewa1024 @tomlm Can we get input on this? Not sure who most appropriate person is.
Attachments with text in a single activity is not yet supported. Implementing this might affect that.
Assigning @seaen for tracking purposes.
@corinagum @compulim @DesignPolice I think we have two options: 1 - If we don't automatically send the text with the image, then we should not clear the text box. 2- If we do send the text with the image, then we should clear the text box.
In my super scientific survey of a few messaging apps, Slack, Teams, iMessage, and Facebook Messenger seem to follow option 2. Telegram and Snapchat follow option 1. For Web Chat, I think option 2 is more appropriate, since we're not expecting users to alter the image like you might in Telegram or Snapchat. But if we can't copy the image into the message, then we should definitely not clear the text box (option 1).
Another thing that I think is slightly jarring in WebChat is that selecting the image also sends the image, whereas in the apps I looked at the user selects the image first and then has to hit a separate send button to send it. When you select and send in one action, the user doesn't preview the message.
-- Details from other apps:
Slack (on desktop):
Teams (on desktop and mobile) - similar to Slack:
iMessage also sends the image with the text, but as separate messages, and it sends the image first:
Facebook Messenger - Similar to iMessage: places image in the message window above the text your previously typed but haven't yet sent and then when you hit send it sends the image message first then the text message.
Telegram sends the image:
Snapchat is has UX similar to Telegram.
@mewa1024 not sure how you had time to work this into your life. Thank you. I agree that having the extra step before sending an image with a message is nice and expected. Also to add a message with it would be cool. I'm starting a new Sketch file with all of these different situations and will see if we can get a look and feel that makes sense across them all.
Read through the alternatives. Two options:
[COMPLICATED] Use the same UX model we introduced with Microsoft Teams:
[SIMPLE] Use the same UX model with introduced with Skype on mobile:
To answer the question in the title of this issue, in either option, do not clear the the text box when the user selects the attachment.
To decide on when to sent the attachment - we should give a user a chance to undo selection of attachment before sending. Can the same message transmit both the text and the attachment? If so, solution #1 results in the better user experience.
Confirmed with @compulim that keeping text and attachment in the same activity is trivial implementation-wise, we just need design specs. Two scenarios I haven't discussed with @DesignPolice yet is, how do we handle multiple attachments? What if there is a mix of attachments where some are images and some are documents?
Related to #1265
yes. will just roll in with #1265
Repro:
After the file is selected and being uploaded, the textbox is emptied. In additional to upload file, the textbox is also emptied when clicking on an action button.
Should we keep "Hello" in the textbox?