search

microsoft / BuildCast

Example UWP Media Application to show best practices
MIT License
451 stars 145 forks source link

Moving Implicit and Connected Animations to markup #22

Closed nmetulev closed 6 years ago

nmetulev commented 6 years ago

Updated BuildCast to use the UWP Community Toolkit v2.1 and markup implicit and connected animations

touseefbsb commented 6 years ago

sadly this repo isn't active enough, so don't know when will this be merged :P

clarkezone commented 6 years ago

@nmetulev there is one regression I've seen so far. You can't set canvas.zindex from markup on the page.. this will make only one page in the app work.. it needs to be called dynamically in the onnavigatingfrom of all pages that are using the defaulthide animation.. not sure the cleanest way to fix, it works to add that code to all pages but there is probably a nicer way: thoughts?

nmetulev commented 6 years ago

Great catch. Is it just the zindex that needs to be set in the onnavigatingfrom/to? Or the animations need to be set then as well?

clarkezone commented 6 years ago

The animation will be set by virtue of any hide animations that are configured using your extension, so it is just the zindex that needs to be set. I have a prototype of this if you’re interested

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Nikola Metulev notifications@github.com Sent: Monday, December 11, 2017 9:21:41 PM To: Microsoft/BuildCast Cc: James Clarke; Comment Subject: Re: [Microsoft/BuildCast] Moving Implicit and Connected Animations to markup (#22)

Great catch. Is it just the zindex that needs to be set in the onnavigatingfrom/to? Or the animations need to be set then as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBuildCast%2Fpull%2F22%23issuecomment-350948504&data=02%7C01%7C%7C263b656a09a24370b93f08d541203b4a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636486529035915335&sdata=AAzYfQ0KJi9fEC%2FxPVfPSYAbyQ52MFfEqUiq8TfTbXY%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABE3OrQzFwDkeG0CLP-MTOC1DNkbGNMzks5s_g1lgaJpZM4QttSh&data=02%7C01%7C%7C263b656a09a24370b93f08d541203b4a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636486529035915335&sdata=dKMXIucNC9fOYRrxSwz4ocvEr3h%2B0x1WYay0Q9qyqxc%3D&reserved=0.

clarkezone commented 6 years ago

Please can you merge master.

nmetulev commented 6 years ago

Merged