ashamis commented 4 years ago

Get smallbank to work with the pbft backend
Create a python pbft flag and then use that to make network.start_and_join work for both raft and pbft
bug fix where we do not return the KV version properly
change to use the standard allocator for pbft message allocations

cimetrics commented 4 years ago

images

codecov-io commented 4 years ago

Codecov Report

Merging #532 into master will decrease coverage by 1.76%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
- Coverage   72.82%   71.06%   -1.76%     
==========================================
  Files         140      140              
  Lines       10475    10470       -5     
==========================================
- Hits         7628     7440     -188     
- Misses       2847     3030     +183

Flag	Coverage Δ
#e2e_BFT	`50.91% <0%> (-0.2%)`	:arrow_down:
#e2e_CFT	`?`
#unit_BFT	`65.11% <ø> (ø)`	:arrow_up:
#unit_CFT	`72.28% <ø> (ø)`	:arrow_up:

Impacted Files	Coverage Δ
src/consensus/pbft/libbyz/Log_allocator.h	`0% <ø> (ø)`	:arrow_up:
src/consensus/pbft/libbyz/Big_req_table.h	`0% <ø> (ø)`	:arrow_up:
src/consensus/pbft/libbyz/Client_proxy.h	`67.05% <0%> (-0.77%)`	:arrow_down:
src/consensus/raft/raftconsensus.h	`0% <0%> (-70.59%)`	:arrow_down:
src/node/rpc/forwarder.h	`41.74% <0%> (-40%)`	:arrow_down:
src/node/nodetonode.h	`60.92% <0%> (-21.84%)`	:arrow_down:
src/consensus/ledgerenclave.h	`72.73% <0%> (-9.09%)`	:arrow_down:
src/node/nodestate.h	`40.21% <0%> (-6.51%)`	:arrow_down:
src/enclave/rpcendpoint.h	`65.63% <0%> (-6.25%)`	:arrow_down:
src/host/notifyconnections.h	`25% <0%> (-5.88%)`	:arrow_down:
... and 9 more