search

microsoft / CCF

Confidential Consortium Framework
https://microsoft.github.io/CCF/
Apache License 2.0
761 stars 205 forks source link

Use typed model values to prevent comparing things that shouldn't be compared. #6166

Closed lemmy closed 1 week ago

lemmy commented 2 weeks ago

Low-risk change.

Squash any type-related discussions, and prevent future incantations of https://github.com/microsoft/CCF/pull/6164/commits/20d89bff161410663d14e0cd2ad0788fe6337409. ;-p

See section about typed model values in https://tla.msr-inria.inria.fr/tlatoolbox/doc/model/model-values.html

achamayou commented 1 week ago

I am sure this will make @eddyashton smile :)

Not sure about "types can only be one letter", but still much better than before!