microsoft / CLAP

Learning audio concepts from natural language supervision
MIT License
486 stars 38 forks source link

Two small bugs: self.clapclap and resample #21

Closed zhifengkong closed 1 year ago

zhifengkong commented 1 year ago

1, If clapclap is used, in the init function you write self.clapclap = xxx but you call self.clap later. 2, In CLAPWrapper resample should have a default value in get_audio_embeddings based on your example code

bmartin1 commented 1 year ago

Hi @FengNiMa,

Thanks for your help! We are not sure what the issue is in 1). We call self.clapcap() only in two functions that relate to audio captioning. As of 2) we added the default value and also fixed other minor related issues in read_audio().