microsoft / CSS-Exchange

Exchange Server support tools and scripts
MIT License
1.22k stars 341 forks source link

[Work Item] Create an additional check to be done for Write Scripts #1906

Open dpaulson45 opened 10 months ago

dpaulson45 commented 10 months ago

Describe the work We want to be able to have a record and accountability for some scripts if they are modified that they should be tested/reviewed when changed. Need to look into a task or something where an additional step is required to be performed in order to allow the PR to be merged.

We are not able to use code owner groups because a modification to a shared script function can modify a write script, thus causing a possible miss for a change that might need additional testing. Plus, then we have a blocker when it comes to actually merging in PRs from internal without an override.

After the script has been determined to be changed, we should create a Work Item that contains detailed steps for repro and things that we need to test out, so it is tracked within this repro. However, we do not need to do this at this time as we only need to do this moving forward when the below scripts have been modified.

Exceptions

Additional Context These are the following scripts that are determined that need to be tested by a different team other than support if ever changed.

dpaulson45 commented 10 months ago

When adding a new script, another process should be triggered to determine if it is a write script or not.