search

microsoft / CSharpClient-for-Kafka

.Net implementation of the Apache Kafka Protocol that provides basic functionality through Producer/Consumer classes. The project also offers balanced consumer implementation.
Other
463 stars 95 forks source link

Kafka 0.9 producer fix #22

Open johnstark opened 8 years ago

johnstark commented 8 years ago

Adding a space for DefaultClientId was required for kafkanet to work with Kafka 0.9. https://issues.apache.org/jira/browse/KAFKA-3088

With this fix: able to successfully produce messages from kafkanet to 0.9 and used the 0.9 Java consumer to consume them.

jthelin commented 8 years ago

@johnstark -- FYI, the PR verification build fails with this change. https://ci.appveyor.com/project/skillrat/kafkanet/build/1.0.0.14-ystcjvtw

Is there some way to make this code support both Kafka 0.8 and 0.9?

johnstark commented 8 years ago

@jthelin, we did verify the fix and it is working with Kafka 0.8 and 0.9. It turns out the mock in this case was assuming the empty string and a space is precisely what the fix required. I just checked in another PR that fixes the mocks.