search

microsoft / CSharpClient-for-Kafka

.Net implementation of the Apache Kafka Protocol that provides basic functionality through Producer/Consumer classes. The project also offers balanced consumer implementation.
Other
463 stars 95 forks source link

Optimization and bubble up ProducerResponseStatus #53

Open jbeacham opened 8 years ago

jbeacham commented 8 years ago

Optimization and bubble up ProducerResponseStatus to producer.Send method.

-Optimized DispatchSerializedData method in DefaultCallbackHandler.cs to use a single foreach method as opposed to multiple foreach statements. -Added offset and partitionId to ProducerResponseStatus and bubbled it all the way to the producer.Send method. Kafka intended for this response to be available to the consumer for logging, health, etc. -Added ShouldReturnOffset() unit test in DefaultCallbackHandlerTest.cs -All Unit Tests passed

msftclas commented 8 years ago

Hi @jbeacham, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@jbeacham, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

jbeacham commented 8 years ago

I do not have access to view the Details of the AppVeyor build fail reasons. Can somebody please let me know what they say.

mhorstma commented 8 years ago

Your PR failed to build because of a misconfigured appveyor build project that was a result of the name change of the github project. After this failed, I cleaned out the bad appveyor build and your PR should build fine now.

jbeacham commented 8 years ago

Awesome, thank you!