Closed obastemur closed 7 years ago
Fixes #47
Thanks for the Quick fix on the bug, and the review involves compile bugs and notes involving Ubuntu Linux 16.04 LTS.
@obastemur why only fail_check a portion of the API calls?
Why change the output of the Hello World example from Hello World!
to SUCCESS
? That doesn't make sense to me.
Cool we have so many people on board 👍
Why change the output of the Hello World example from Hello World! to SUCCESS? That doesn't make sense to me.
@jcoffland That comes straight from our native tests. Hello World
indeed makes more sense. Thanks for this.
@obastemur why only fail_check a portion of the API calls?
Good idea to show to devs each and every single method may return an error value there.
@kphillisjr @liminzhu @jcoffland Thanks for the review
/cc @liminzhu