search

microsoft / Chakra-Samples

Repository for Chakra JavaScript engine related samples.
MIT License
216 stars 84 forks source link

Update ChakraCore samples to latest JSRT #48

Closed obastemur closed 7 years ago

obastemur commented 7 years ago

/cc @liminzhu

obastemur commented 7 years ago

Fixes #47

kphillisjr commented 7 years ago

Thanks for the Quick fix on the bug, and the review involves compile bugs and notes involving Ubuntu Linux 16.04 LTS.

liminzhu commented 7 years ago

@obastemur why only fail_check a portion of the API calls?

jcoffland commented 7 years ago

Why change the output of the Hello World example from Hello World! to SUCCESS? That doesn't make sense to me.

obastemur commented 7 years ago

Cool we have so many people on board 👍

obastemur commented 7 years ago

Why change the output of the Hello World example from Hello World! to SUCCESS? That doesn't make sense to me.

@jcoffland That comes straight from our native tests. Hello World indeed makes more sense. Thanks for this.

@obastemur why only fail_check a portion of the API calls?

Good idea to show to devs each and every single method may return an error value there.

obastemur commented 7 years ago

@kphillisjr @liminzhu @jcoffland Thanks for the review