search

microsoft / Chakra-Samples

Repository for Chakra JavaScript engine related samples.
MIT License
216 stars 84 forks source link

Add Cmake for Chakra Examples #50

Open kphillisjr opened 7 years ago

kphillisjr commented 7 years ago

This implements the cmake builder for the Chakra Core samples. This also gets the Chakra OpenGL Engine example running on Ubuntu 16.04LTS. To build this example just run build.sh.

Also as a note, This needs testing/fixes for windows.

liminzhu commented 7 years ago

Thank you @kphillisjr . @obastemur can you take a look?

kphillisjr commented 7 years ago

@liminzhu, This is on Hold until I redo the main ChakraCore pull. ( see: https://github.com/Microsoft/ChakraCore/pull/2084 )

kphillisjr commented 7 years ago

@liminzhu, This pull request is a bit outdated. I made a couple of changes in another branch where I condensed most of the commits in this into two or three total. You can test the new changes in the steps mentioned on this ChakraCore pull request ( https://github.com/Microsoft/ChakraCore/pull/2111 )

kphillisjr commented 7 years ago

@liminzhu, There was some major changes to how I did things in a way that would greatly simplify the linking of ChakraCore. The new pull request ( Microsoft/ChakraCore#2138 ) introduces a new library on XPlat called ChakraCoreStatic. This reduces the number of libraries that users haft to link to get ChakraCore working, and also addresses the runtime issues chakracore displays on OSX/Linux in regards to library initialization. I will need to rebase this pull request on the changes made by this, and hopefully I could get some of the other developers to sign off on one of the fixes for automatic configuration of ChakraCore using cmake functionality.