search

microsoft / Chakra-Samples

Repository for Chakra JavaScript engine related samples.
MIT License
216 stars 84 forks source link

xplat: new shared lib sample #73

Closed obastemur closed 7 years ago

obastemur commented 7 years ago

/cc @liminzhu . We may use this sample inside the package.

liminzhu commented 7 years ago

Thanks @obastemur ! Left some comments. Would also edit readme a bit to provide the option of using 2.0 binary packages once they are online.

obastemur commented 7 years ago

Would also edit readme a bit to provide the option of using 2.0 binary packages once they are online.

We may do it in the package instead?

liminzhu commented 7 years ago

We may do it in the package instead?

Including the sample in the package? Not sure if this is the right call since it's not a necessity for the binary package, and I'd prefer having a wiki about various channels to download packages (Azure, nuget, homebrew) and linking to this sample as how to use the package (working on the wiki now actually). Anyways, we can discuss it but this isn't a blocking issue for the sample since we can make edits later.

The sample looks good now and feel free to merge :shipit: .

obastemur commented 7 years ago

@liminzhu Thanks for the review!