adding a Qt's wrapper that allows:

microsoft / Chakra-Samples

Repository for Chakra JavaScript engine related samples.

MIT License

216 stars 84 forks source link

adding a Qt's wrapper that allows: #87

Open lemmel opened 6 years ago

lemmel commented 6 years ago

to access from ChakraCore to Qt's Object
set variables from C++
get variables from ChakraCore

Furthermore it can be a useful because it offers several examples:

access to variables from and to ChakraCore
registering attribute's object and be able to get notified when they are changed

msftclas commented 6 years ago

All CLA requirements met.

liminzhu commented 6 years ago

Thanks for the contribution @lemmel !

@Microsoft/chakra-developers anybody familiar with Qt?

obastemur commented 6 years ago

I actually looked a bit while ago and I really liked the effort here.

Concerns;

I'm not sure if we can test this through before taking it
The looks and feel of the code is not matching to our code && design guidelines
Licensing issues may arise ?

Nonetheless, this is an epic effort and I'm sure it will be beneficial for many people using QT.

lemmel commented 6 years ago

It is as you want: I can alter the code, add unit test and so on. Just ask.

P.S. : I will be AFK 2 weeks, so I will not be able to answer or work on this until later in the month. P.P.S. : I don't see any licensing problem as I give it to public domain, and Qt's licensing has nothing to do here.