search

microsoft / ChakraCore-Debugger

Debugging companion library for the ChakraCore JavaScript engine
MIT License
32 stars 25 forks source link

office build fixes #67

Closed asachin96 closed 5 years ago

asachin96 commented 5 years ago

In office build environment, unused parameter warning is treated as error (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4100?view=vs-2019). This PR is to fix that.

akroshg commented 5 years ago

Looks good - thanks @asachin96

akrantz commented 5 years ago

Thanks @akroshg ! I know it's been a while but @asachin96 is now working on the console redirection.

akrantz commented 5 years ago

Also, will you go ahead and merge this?