search

microsoft / ChakraCore-Debugger

Debugging companion library for the ChakraCore JavaScript engine
MIT License
32 stars 25 forks source link

do not use SolutionDir for project include paths #68

Closed akrantz closed 5 years ago

akrantz commented 5 years ago

Use $(ChakraCoreDebuggerDir) instead of $(SolutionDir) for include paths. Rename $(DepsDirectoryPath) to $(ChakraCoreDebuggerDepsDir) for the deps subdirectory.

This allows the projects to be used in other solutions, because the include paths do not depend upon the solution directory.

akrantz commented 5 years ago

@akroshg I wanted to give some background on this pull request. There are no code changes here; only changes to the VS projects so they can be used within another solution. This allows being able to make this repository a submodule in https://github.com/Microsoft/react-native-windows and using the projects within a solution in that repository.

The changes for that can be seen here: https://github.com/Microsoft/react-native-windows/compare/rnwcpp-preview...akrantz:chakracore-debugger-submodule

But in order to make those changes, I need to first have this pull request reviewed and merged.