search

microsoft / ChakraCore-wiki

A mirror of the ChakraCore wiki to enable pull requests on the Wiki.
https://github.com/Microsoft/ChakraCore/wiki
Other
22 stars 30 forks source link

Rename LICENSE{.md -> .txt} and clarify language to ensure it is understood that this license applies only to the Wiki. #11

Closed dilijev closed 7 years ago

dilijev commented 8 years ago

Renaming the LICENSE.md to LICENSE.txt ensures that it does not show up in the Wiki (.md files show up but .txt files like README.txt do not) as LICENSE as it does now. Not exposing this LICENSE file through the Wiki view reduces the likelihood that people could mistake this LICENSE file as the LICENSE of ChakraCore's source code (that license is found in ChakraCore's LICENSE.txt file.

This change also clarifies the language of the LICENSE.txt file to indicate that it applies to the ChakraCore wiki (and not the ChakraCore source code).

dilijev commented 8 years ago

@bterlson @liminzhu I noticed that this LICENSE file is visible under https://github.com/Microsoft/ChakraCore/wiki/LICENSE and might be misinterpreted as a LICENSE for the ChakraCore code rather than the Wiki itself. I thought some clarifying language was a good idea, but I wanted to run it by you first. Not sure what legal guidance there would be for this situation.

Alternatively, I believe that renaming this file to LICENSE.txt would make it only appear in the Wiki repo (i.e. in the file list of https://github.com/Microsoft/ChakraCore-wiki) without appearing in the Wiki itself.

dilijev commented 8 years ago

Added a README.txt and confirmed that .txt files don't show up in the Wiki view.

dilijev commented 8 years ago

Ping @liminzhu @bterlson what do you think?

bterlson commented 8 years ago

Sorry I missed this the first time...

I think renaming to .txt is fine. I don't think the final paragraph clarification is necessary personally but it's fine to have it.

dilijev commented 8 years ago

I agree, I think with the other changes (renaming it to hide it from the Wiki view, and the clarification to the first paragraph), the final paragraph is unnecessary.