microsoft / ChakraCore-wiki

A mirror of the ChakraCore wiki to enable pull requests on the Wiki.
https://github.com/Microsoft/ChakraCore/wiki
Other
22 stars 30 forks source link

Add references for new JSRT API #13

Closed alexgwolff closed 7 years ago

alexgwolff commented 8 years ago

Add references for :

dilijev commented 8 years ago

@liminzhu FYI

liminzhu commented 8 years ago

Thanks for the PR @alexgwolff ! Given the experimental status of those APIs (we may change them very soon), let's hold on to this PR for now. There're a bunch of other experimental APIs which are in the headers but not in the wiki references (e.g. debugging/TTD APIs and module APIs). We can either add all of them in the wiki now, or add them once they're ready for consumption (I prefer the latter approach).

obastemur commented 8 years ago

Personally, I really appreciate the effort here. In addition to keeping it on hold we may ping here once the new API is ready/merged. So @alexgwolff may update this PR.

@liminzhu Thoughts? @alexgwolff ?

//cc @jianchun

alexgwolff commented 8 years ago

Just adding experimental is enough? Ex: [[JsSerializeScriptUtf8]] experimental

alexgwolff commented 7 years ago

@obastemur

obastemur commented 7 years ago

@alexgwolff I will ping you (to update this PR) once we update the API. Thanks!

obastemur commented 7 years ago

@alexgwolff We have updated the ChakraCore master branch with the latest JSRT API. See https://github.com/Microsoft/ChakraCore/blob/master/lib/Jsrt/ChakraCore.h#L167-L554

Thanks!

alexgwolff commented 7 years ago

Okay, I'll update the docs @obastemur

jcoffland commented 7 years ago

I would like to point out that not only have functions been added but some functions have been removed. E.g. JsStringToPointer(). This breaks most of the examples.

dilijev commented 7 years ago

/cc @liminzhu - we should ensure we update samples that are broken by recent changes.

liminzhu commented 7 years ago

https://github.com/Microsoft/Chakra-Samples/pull/48

alexgwolff commented 7 years ago

@dilijev @obastemur

obastemur commented 7 years ago

My initial look is LGTM but @liminzhu or @dilijev has better opinion on this stuff.

liminzhu commented 7 years ago

:shipit:

Thank you @alexgwolff .

dilijev commented 7 years ago

LGTM. I think everyone approves. Merging.

dilijev commented 7 years ago

Deployed the changes to https://github.com/Microsoft/ChakraCore/wiki