Closed alexgwolff closed 7 years ago
@liminzhu FYI
Thanks for the PR @alexgwolff ! Given the experimental status of those APIs (we may change them very soon), let's hold on to this PR for now. There're a bunch of other experimental APIs which are in the headers but not in the wiki references (e.g. debugging/TTD APIs and module APIs). We can either add all of them in the wiki now, or add them once they're ready for consumption (I prefer the latter approach).
Personally, I really appreciate the effort here. In addition to keeping it on hold we may ping here once the new API is ready/merged. So @alexgwolff may update this PR.
@liminzhu Thoughts? @alexgwolff ?
//cc @jianchun
Just adding experimental is enough? Ex: [[JsSerializeScriptUtf8]] experimental
@obastemur
@alexgwolff I will ping you (to update this PR) once we update the API. Thanks!
@alexgwolff We have updated the ChakraCore master branch with the latest JSRT API. See https://github.com/Microsoft/ChakraCore/blob/master/lib/Jsrt/ChakraCore.h#L167-L554
Thanks!
Okay, I'll update the docs @obastemur
I would like to point out that not only have functions been added but some functions have been removed. E.g. JsStringToPointer()
. This breaks most of the examples.
/cc @liminzhu - we should ensure we update samples that are broken by recent changes.
@dilijev @obastemur
My initial look is LGTM but @liminzhu or @dilijev has better opinion on this stuff.
:shipit:
Thank you @alexgwolff .
LGTM. I think everyone approves. Merging.
Deployed the changes to https://github.com/Microsoft/ChakraCore/wiki
Add references for :