search

microsoft / ChakraCore-wiki

A mirror of the ChakraCore wiki to enable pull requests on the Wiki.
https://github.com/Microsoft/ChakraCore/wiki
Other
22 stars 30 forks source link

Fix #19: Fix Build Status table for changes introduced in Microsoft/ChakraCore#1962 #32

Closed dilijev closed 7 years ago

dilijev commented 7 years ago

Fixes #19 See Microsoft/ChakraCore#1962

dilijev commented 7 years ago

@obastemur @liminzhu

dilijev commented 7 years ago

I will make a corresponding change to the README once this is merged.

liminzhu commented 7 years ago

👍

ThomsonTan commented 7 years ago

Seems this fixed the pending OSX build status.

dilijev commented 7 years ago

This is a text-only change to the Wiki. I also updated the required checks for the master branch in the Microsoft/ChakraCore repo settings -- that's what fixed the issue.

ThomsonTan commented 7 years ago

You are right, I entered this PR via link https://github.com/Microsoft/ChakraCore/pull/2634.

dilijev commented 7 years ago

Ah, I see. FWIW, that's also just a text-only change to the README. The relevant setting was in the GitHub repo metadata/settings, not in our sources. :)