search

microsoft / ChakraCore-wiki

A mirror of the ChakraCore wiki to enable pull requests on the Wiki.
https://github.com/Microsoft/ChakraCore/wiki
Other
22 stars 30 forks source link

Replace Release Notes page with redirect to Release Notes section of Roadmap. #39

Closed dilijev closed 7 years ago

dilijev commented 7 years ago

The Roadmap#release-notes anchor will now direct to e.g. https://github.com/dilijev/ChakraCore-wiki/blob/523afface5bdc1cc90f01f36c5f63e0c1bbe6212/Roadmap.md#release-notes

liminzhu commented 7 years ago

Oops already re-directed release notes page manually before I see your PR 😄.

Tbh I'm personally fine without a top-level #Release Notes since I see #Future, #ChakraCore 1.4, #ChakraCore 1.3, etc. as headers on the same level. TypeScript did something similar.

dilijev commented 7 years ago

So we need the anchor for # Release Notes so that the link Roadmap#release-notes works. I'm okay with it being a top-level heading. I'll update the PR.

dilijev commented 7 years ago

Created an alternate PR instead so the two options can be compared.

dilijev commented 7 years ago

See discussion on #40. Going with #39 (a.k.a. Option 2 discussed in #40).