search

microsoft / ChakraCore-wiki

A mirror of the ChakraCore wiki to enable pull requests on the Wiki.
https://github.com/Microsoft/ChakraCore/wiki
Other
22 stars 30 forks source link

Add instructions for building ICU on Windows #50

Closed jackhorton closed 6 years ago

jackhorton commented 6 years ago

It looks like Microsoft/ChakraCore.wiki.git is two commits ahead of this repo, so I suppose those can come along for the ride too.

jackhorton commented 6 years ago

Fixes https://github.com/Microsoft/ChakraCore/issues/4705

dilijev commented 6 years ago

@jackhorton There is no pump, only manual sync because velocity is slow. I recommend manually bringing them in sync before open a PR. I've synced them now so your merge will only merge your unique changes. (Though the PR will continue to show the extra commits.)

jackhorton commented 6 years ago

I think I resolved all of the comments.

liminzhu commented 6 years ago

:shipit: