search

microsoft / ClearScript

A library for adding scripting to .NET applications. Supports V8 (Windows, Linux, macOS) and JScript/VBScript (Windows).
https://microsoft.github.io/ClearScript/
MIT License
1.77k stars 148 forks source link

V8 Crash #478

Closed TomasPospisil closed 1 year ago

TomasPospisil commented 1 year ago

Hi @ClearScriptLib,

we ran into an issue during starting V8 Engine which caused crash of entire application. The issue was this:

dotnet: /home/jerry/ClearScript/ClearScriptV8/V8IsolateImpl.cpp:1825: V8IsolateImpl::ExecutionScope V8IsolateImpl::EnterExecutionScope(V8IsolateImpl::ExecutionScope , size_t *): Assertion `m_spHeapWatchTimer.IsEmpty()' failed.

We never seen such crash in the application, so it must be "unique". Do you know what could have gone wrong from this little piece of code?

ClearScriptLib commented 1 year ago

Hi @TomasPospisil,

Do you know what could have gone wrong from this little piece of code?

We're investigating that – as well as why assertion code was included in the official build 🤔

Thank you!

ClearScriptLib commented 1 year ago

Hi @TomasPospisil,

Is the crash reproducible? Do you have a code sample you could share?

Thanks!

TomasPospisil commented 1 year ago

Hi @ClearScriptLib,

sorry for late reply. The crash is not reproducible at all, it was just an occasional crash. However it was run on ClearScript version 7.3.4

ClearScriptLib commented 1 year ago

Version 7.3.7 fixes at least one cause of this crash. Please reopen this issue if you encounter it in ClearScript 7.3.7 or newer builds.