microsoft / CloudAdoptionFramework

Code samples and extended documentation to support the guidance provided in the Microsoft Cloud Adoption Framework
https://aka.ms/CAF
Creative Commons Attribution 4.0 International
864 stars 621 forks source link

Specified delimeter is not allowed for "Compute/virtualMachines - Windows (vm)" #151

Closed robm82 closed 5 months ago

robm82 commented 1 year ago

I have been setting up the naming tool, and I get a message saying that the specified delimiter is not allowed for this resource type and has been removed:

image

I am using the default dash delimiter which is a "-", which should be an acceptable delimiter according to the naming tool (or have I misunderstood the regex?):

image

robm82 commented 1 year ago

I think it might be saying that the delimiter isn't allowed as the name length would have been over 15 characters. So I think it is removing the dash delimiter to keep the resource name to a minimum. Would it be worth updating the message?

robm82 commented 1 year ago

Again on this point, is 15 characters really the hard limit for creating Windows Virtual Machines? In the Azure portal I can create a VM up to 64 characters in length? Is it limited to 15 characters due to the Windows NetBIOS name being limited to 15 characters, and if you create a Windows VM longer than 15 characters it will truncate the name? image

psilantropy commented 1 year ago

I worked around this by making the location optional for Windows VM, and then making additional environments selectable. E.g. Aprd Bprd, A and B representing locations shortened from AXX and BXX.

This means it can be used for single Windows VMs, but doesn't function properly when generating multiple resources.

Edit: I did one better. Make a custom component for environment/location combined. Exclude all resource types from using this. Then edit the Windows VM resource type, add this component back, and exclude environment and location.

Such an awesome tool.

Zimmergren commented 5 months ago

The AzNamingTool repo moved: https://github.com/mspnp/AzureNamingTool Please continue discussions or file new tickets in the new repo if there are still any issues! Thanks.

cc @psilantropy , @robm82 FYI @BryanSoltis