microsoft / CloudAdoptionFramework

Code samples and extended documentation to support the guidance provided in the Microsoft Cloud Adoption Framework
https://aka.ms/CAF
Creative Commons Attribution 4.0 International
854 stars 614 forks source link

AzureNamingTool: Globally optional in version 2.5.0 does not apply when generating multiple resource type names #154

Closed erlendjd closed 1 year ago

erlendjd commented 1 year ago

After migrating optional components to new globally optional type in version 2.5.0 we have run into an issue when generating multiple resource type names at once. The component is not optional when generating multiple resource type names, but is optional when generating single resource type name.

First image showing that the component is optional when generating single resource type name: image As you can see it is optional and we can click generate whitout selecting a value for the component.

Second image showing that the component is not optional when generating multiple resource type names: image As you can see it is not optional and we cant click generate without selecting a value for the component.

Third image showing that we can click generate if a value is set in the component: image

Hope to see this fixed in next version.

BryanSoltis commented 1 year ago

Hi @erlendjd,

Thank you for your feedback. This is a current limitation of the tool due to the way it handles optional components. We have a backlog item to update this, and we will address it in a future. release.

Thank you!

-Bryan

erlendjd commented 1 year ago

Great, thanks for the fast response!