Open jholovacs opened 8 years ago
Thanks a lot for the bug report. Don't you mind to create a PR?
I didn't seem to have access to do a pr. Do I have to merge into one of the existing branches?
On Tue, Mar 22, 2016 at 2:54 PM Sergey Teplyakov notifications@github.com wrote:
Thanks a lot for the bug report. Don't you mind to create a PR?
— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Microsoft/CodeContracts/issues/397#issuecomment-199989093
Hm... I think there is no such thing as permissions for PR. To make a pr you need to clone the repo to your repo, make a change there and then make a PR.
Well, I did clone the repo, branched locally, made a change, committed locally, tried to push my branch to the repo and make the PR off of that, but I couldn't. Should I have done something different?
On Tue, Mar 22, 2016 at 3:17 PM Sergey Teplyakov notifications@github.com wrote:
Hm... I think there is no such thing as permissions for PR. To make a pr you need to clone the repo to your repo, make a change there and then make a PR.
— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Microsoft/CodeContracts/issues/397#issuecomment-200002628
First step - you need to fork using github (this button called Fork at the upper right corner of this page).
The reason why is following: you don't have permissions to push to this repo. Otherwise everyone who is working on large project would see all the branches that hundreds of people are using.
So just a fork using github first and then do exactly what you did.
This can be closed, right?
yup. On May 16, 2016 3:59 AM, "David Hesselbom" notifications@github.com wrote:
This can be closed, right?
— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Microsoft/CodeContracts/issues/397#issuecomment-219370225
patch is as follows: