search

microsoft / Cognitive-Face-Windows

Windows SDK for the Microsoft Face API, part of Cognitive Services
https://www.microsoft.com/cognitive-services/en-us/face-api
Other
177 stars 161 forks source link

Expand NuSpec to include Xamarin.iOS & Xamarin.Android. #25

Open pierceboggan opened 7 years ago

pierceboggan commented 7 years ago

Mobile developers want to take advantage of this package, but currently cannot due to targeting issues. Because there's really nothing Windows-specific in this (we're just pushing and pulling down data from the Face SDK service), this should be retargeted to include Xamarin.iOS and Xamarin.Android.

More information here: https://docs.microsoft.com/en-us/nuget/guides/create-cross-platform-packages

huxuan commented 7 years ago

Hi @pierceboggan, thanks for your suggestion and information. To be honest, I personally have no experience on Xamarin and by my first glance at the guide, I think it will deeply change the current code base. Considering we do have Face SDK for iOS [1] and Android [2], I do not think it is necessary to support Xamarin currently which will make the maintenance even harder. Feel free to let me know if I made anything wrong.

[1] https://github.com/Microsoft/Cognitive-Face-iOS [2] https://github.com/Microsoft/Cognitive-Face-Android

pierceboggan commented 7 years ago

@huxuan: Why would it change the codebase? I certainly understand how it would change the codebase for those Cognitive Service SDKs with platform-specific APIs, but this is just making network calls and thus this code is completely cross-platform. There would be no changes to the codebase required at all, it's just a matter of updating the NuSpec.

As a reference, we have done several very popular blog posts using the Face SDK library, which is just downloaded from GitHub, added as a reference, and compiled directly. No changes were required to make this work. To make it easier for our developers to use these SDKs directly from NuGet, all we need to do is update the NuSpec.

I also anticipate you will at some point migrate this library from PCL -> .NET Standard, which Xamarin also supports.

huxuan commented 7 years ago

Hi @pierceboggan, sorry for my poor experience on Xamarin, seems I was mislead by the reference [1]. Can you be specific about what changes are necessary for the migration? If only minor changes are necessary, it would be great if you can send a pull request directly.

[1] https://docs.microsoft.com/en-us/nuget/guides/create-cross-platform-packages

pierceboggan commented 7 years ago

@huxuan: I would love to. 👍 I'll ping here again when I have a PR ready.