search

microsoft / Cognitive-Vision-Android

Android SDK for the Microsoft Computer Vision API, part of Cognitive Services.
https://www.microsoft.com/cognitive-services/en-us/computer-vision-api
Other
139 stars 80 forks source link

Remove usage of TextUtils from VisionServiceRestClient #4

Closed angerycoder closed 7 years ago

angerycoder commented 7 years ago

The class VisionServiceRestClient uses a utility class TextUtils from android to convert a String[] to a String using a delimiter. However this makes it difficult to use this Java API outside of Android. If you could change it to use String.join(delimiter, array) this would remove the dependency of the client on Android libraries. However String.join is available only on Java 8 and above, so using Apache Common's StringUtils.join would be a better approach.

Thanks, Sushil

angerycoder commented 7 years ago

Thanks a lot for working on this @Kialandi