Non-trivial fixes:
For CRootVisualizer::m_size, we were storing the 4 byte unsigned int as a 8-byte unsigned long long. Even though the API that it comes from uses unsigned int, and the API we use it for uses an unsigned int. So I just converted the whole thing to use unsigned int.
For CChildVisualizer::CreateEvaluationResult, we were passing in pType even though pType is always null. I just removed pType altogether and just pass in null.
Other fixes were simple (1 suppression, 1 cast to 64 bit int, 3 needed to have matching SAL notation as their declaration).
Non-trivial fixes: For
CRootVisualizer::m_size
, we were storing the 4 byte unsigned int as a 8-byte unsigned long long. Even though the API that it comes from uses unsigned int, and the API we use it for uses an unsigned int. So I just converted the whole thing to use unsigned int.For
CChildVisualizer::CreateEvaluationResult
, we were passing inpType
even thoughpType
is always null. I just removedpType
altogether and just pass in null.Other fixes were simple (1 suppression, 1 cast to 64 bit int, 3 needed to have matching SAL notation as their declaration).