search

microsoft / ConcordExtensibilitySamples

Visual Studio Debug Engine Extensibility Samples
Other
121 stars 50 forks source link

Fix Code Analysis issues #101

Closed calgagi closed 12 months ago

calgagi commented 1 year ago

Non-trivial fixes: For CRootVisualizer::m_size, we were storing the 4 byte unsigned int as a 8-byte unsigned long long. Even though the API that it comes from uses unsigned int, and the API we use it for uses an unsigned int. So I just converted the whole thing to use unsigned int.

For CChildVisualizer::CreateEvaluationResult, we were passing in pType even though pType is always null. I just removed pType altogether and just pass in null.

Other fixes were simple (1 suppression, 1 cast to 64 bit int, 3 needed to have matching SAL notation as their declaration).

gregg-miskelly commented 1 year ago

Including @xisui-MSFT

calgagi commented 12 months ago

Thanks Gregg!!